Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ WPF Gallery ] Added PageHeader control and created DataTemplate for navigation card #630

Closed
wants to merge 2 commits into from

Conversation

dipeshmsft
Copy link
Member

@dipeshmsft dipeshmsft commented Aug 26, 2024

Description

Fixes #629

Added PageHeader control and included the control in all the pages of the gallery application. Apart from that, I have removed DataTemplate from group pages and created a Templates.xaml file which has the DataTemplate.

Microsoft Reviewers: Open in CodeFlow

@himgoyalmicro himgoyalmicro added the * NO MERGE * metadata: The PR is not ready for merge yet (see discussion for detailed reasons) label Sep 25, 2024
@dipeshmsft
Copy link
Member Author

Keep in mind #646 Accessibility issue, before merging this. This PR can probably reopen the issue and make it more harder to resolve.

@dipeshmsft dipeshmsft closed this Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
* NO MERGE * metadata: The PR is not ready for merge yet (see discussion for detailed reasons) WPF Gallery
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce PageHeader in WPF Gallery
2 participants